Skip to content

Fix unnecessary new line in Alert snippet #4776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master-mysterious-egg-next
Choose a base branch
from

Conversation

subhadeepdev
Copy link

No description provided.

ged-odoo and others added 9 commits May 22, 2025 06:51
This commit introduces a full rewrite of the website builder to leverage
the OWL framework and the new HTML editor. The goal is to modernize the
codebase, improve maintainability, and provide a more reactive and
modular architecture.

A major part of this refactoring is the complete rethinking of how
options are defined. They are now implemented as OWL components or simple
template-driven views, and registered as plugins. The system introduces
two distinct concepts: *options*, which handle the user interface, and
*actions*, which encapsulate the actual DOM or HTML updates.

The builder code is now split into two addons:
- `html_builder`: contains a shared foundation for building HTML UIs,
  designed to be reusable across apps, including mass mailing.
- `website`: contains all website-specific logic and components.

The legacy builder code has not been removed yet, as parts of it are
still in use, most notably in the mass mailing application. It will be
removed in the near future.

Many thanks to everyone who contributed to this project, whether through
code, testing, reviews, design, or support — your efforts made this major
milestone possible. Also, this sentence was totally not generated by a AI
language model.

Co-authored-by: aans-odoo <[email protected]>
Co-authored-by: Alessandro Lupo <[email protected]>
Co-authored-by: Alice Gaudon <[email protected]>
Co-authored-by: Antoine Guenet <[email protected]>
Co-authored-by: Augustin (duau) <[email protected]>
Co-authored-by: Benoit Socias <[email protected]>
Co-authored-by: chdh-odoo <[email protected]>
Co-authored-by: Davide Bonetto <[email protected]>
Co-authored-by: Denis Rygaert <[email protected]>
Co-authored-by: divy-odoo <[email protected]>
Co-authored-by: emge-odoo <[email protected]>
Co-authored-by: fdardenne <[email protected]>
Co-authored-by: FrancoisGe <[email protected]>
Co-authored-by: Géry Debongnie <[email protected]>
Co-authored-by: Guillaume Jacquet <[email protected]>
Co-authored-by: Jinjiu Liu <[email protected]>
Co-authored-by: ksbh-odoo <[email protected]>
Co-authored-by: Louis (loco) <[email protected]>
Co-authored-by: Mohammed Shekha <[email protected]>
Co-authored-by: Nicolas Bayet <[email protected]>
Co-authored-by: panv-odoo <[email protected]>
Co-authored-by: paru-odoo <[email protected]>
Co-authored-by: Rahil Ghanchi <[email protected]>
Co-authored-by: Robin Lejeune (role) <[email protected]>
Co-authored-by: Rodolpho Lima <[email protected]>
Co-authored-by: Sanjay Sharma <[email protected]>
Co-authored-by: Sébastien Blondiau <[email protected]>
Co-authored-by: Sébastien Geelen <[email protected]>
Co-authored-by: Serhii Rubanskyi - seru <[email protected]>
Co-authored-by: Soukéina Bojabza <[email protected]>
Co-authored-by: Subhadeep <[email protected]>
Co-authored-by: visp-odoo <[email protected]>
Because when we change the link element in the popover and apply, we
always close the current one and open a new one, the loading at the apply
is redundant. We do the reopening to let the overlay plugin reposition popover,
and let browser handle the relative/root-relative url to add the domain.
Logo can have two views: image and a text one, and so
we pass the view of the one that's displayed right now.
Or, if the logo is hidden, we pass the image logo.
@robodoo
Copy link

robodoo commented May 22, 2025

This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg-next, it needs to be retargeted before it can be merged.

emge-odoo and others added 3 commits May 22, 2025 15:42
Before: In edit mode, creating an alert snippet would create an empty
new line at the begining of the snippet.
@subhadeepdev subhadeepdev force-pushed the master-mysterious-egg-next-sdev branch from 9c93dd9 to 76c1c44 Compare May 22, 2025 13:48
@subhadeepdev subhadeepdev marked this pull request as ready for review May 22, 2025 13:48
@robodoo
Copy link

robodoo commented May 22, 2025

This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg-next, it needs to be retargeted before it can be merged.

@ged-odoo ged-odoo force-pushed the master-mysterious-egg-next branch 8 times, most recently from 921bf70 to 18d31a3 Compare May 28, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants